Commit graph

646 commits

Author SHA1 Message Date
Mislav Marohnić
bc40514506 Simplify building the MSI installer
Now that there is a ZIP archive to download, to avoid the complexities
of unzipping through Node.js we use hub to download the `.zip`, extract
it, and eventually upload the `.msi` back to the release.
2020-01-29 15:23:05 +01:00
Mislav Marohnić
7a1ae751de Use goreleaser to bump Homebrew formula 2020-01-29 14:00:25 +01:00
Mislav Marohnić
739b0af0a6
Merge pull request #272 from cli/windows-urls
Fix `pr create` preview in browser flow for Windows
2020-01-29 12:25:27 +01:00
Mislav Marohnić
fe7cdd8ab7 Extract web browser launching to a package
This fixes opening URLs with `&` on Windows.
2020-01-29 11:49:38 +01:00
Nate Smith
ace404d2fa
Merge pull request #269 from cli/tell-us-all-the-things-please
Add feedback to README
2020-01-28 15:32:39 -06:00
Billy Griffin
b5df8c2251 Make it more clear that this is a survey for users 2020-01-28 13:28:11 -07:00
Billy Griffin
6b44db3590 Add feedback to README
Added google form for feedback and linked to contributing for issue/PR contribution guidance.
2020-01-28 13:26:06 -07:00
Nate Smith
619e5b9e58
Merge pull request #264 from cli/new-repo-name
Have update notifier and changelog link use the new repo name
2020-01-28 13:44:28 -06:00
Nate Smith
9345571ee8
Merge pull request #266 from cli/non-github-remotes
Fix parsing non-GitHub remotes
2020-01-28 13:43:33 -06:00
Mislav Marohnić
8453bf679c Fix parsing non-GitHub remotes
Otherwise, the remote URL translation mechanism had crashed when
encountering a non-Github.com git remote.
2020-01-28 19:51:44 +01:00
Mislav Marohnić
7b28605e6f Fix current changelog link in gh version
Also allow pre-release tags.
2020-01-28 18:31:12 +01:00
Mislav Marohnić
4c75270ab1
Merge pull request #263 from cli/source-note
add note about source compilation
2020-01-28 18:24:31 +01:00
Mislav Marohnić
1c74227ed7 Use new repo name for update notifier and changelog 2020-01-28 18:22:29 +01:00
vilmibm
55c7e2abbb fix link formatting 2020-01-28 11:16:51 -06:00
vilmibm
f1dddead5c note about source compilation 2020-01-28 11:13:09 -06:00
Nate Smith
1f86bf0456
Merge pull request #261 from cli/docs
minor doc updates
2020-01-28 11:06:36 -06:00
Nate Smith
9133ddb236
more pixels 2020-01-28 11:02:44 -06:00
vilmibm
c5a79e36da nicer screenshot 2020-01-28 10:43:04 -06:00
Nate Smith
25dc2b4a14
Merge pull request #258 from cli/blank-title
prevent graphql error
2020-01-28 10:21:11 -06:00
vilmibm
9025838448 update error text 2020-01-28 10:20:59 -06:00
vilmibm
f2b6f4b802 minor doc updates 2020-01-28 10:20:19 -06:00
Nate Smith
d753f7e5b7
Merge pull request #257 from cli/update-feedback-form
Add updated feedback form link
2020-01-27 16:15:16 -06:00
vilmibm
bfd1d804a8 prevent graphql error 2020-01-27 16:00:11 -06:00
Amanda Pinsker
250286d531
Add updated feedback form link 2020-01-27 12:55:57 -08:00
Nate Smith
964da06793
Update readme (#255)
* update docs

- rewrite readme
- add releases.md

* whitespace

* add docs link

* do not store screenshot in repo

* simplift test release instructions
2020-01-27 14:11:44 -06:00
Mislav Marohnić
5a59a8b117 Add contributing.md (#252) 2020-01-24 12:44:15 -06:00
Nate Smith
83073f84a6
Merge pull request #253 from github/copy-release-no-sourcemaps
Fix copy-release action
2020-01-24 10:55:54 -06:00
Nate Smith
01df5da822
Merge pull request #254 from github/cli-rename
Rename to `cli/cli`
2020-01-24 09:21:38 -06:00
Mislav Marohnić
a710893fc1 Rename to cli/cli 2020-01-24 16:08:52 +01:00
Mislav Marohnić
d97c3a0648 Scrub sourcemaps from copy-release action 2020-01-23 19:11:05 +01:00
Nate Smith
11bfa658fb Merge pull request #250 from github/no-errors-wrap
Migrate away from `errors.Wrap()`
2020-01-23 09:51:47 -06:00
Mislav Marohnić
b44dad2319 Merge remote-tracking branch 'origin/master' into no-errors-wrap 2020-01-23 16:46:56 +01:00
Nate Smith
a0f2e1736a Merge pull request #244 from github/ghrepo-interface
Extract common interface for a GitHub Repository
2020-01-23 09:39:16 -06:00
Nate Smith
bf0f345ea3 Merge pull request #243 from github/display-url
Extract helper for URL display
2020-01-23 09:36:40 -06:00
Mislav Marohnić
c5960f0906 Merge remote-tracking branch 'origin/master' into ghrepo-interface 2020-01-23 16:36:22 +01:00
Nate Smith
55a5d19252 Merge pull request #247 from github/issue-pr-view-docs
Tweak `issue/pr view` documentation
2020-01-23 09:35:38 -06:00
Nate Smith
3764e25921 Merge pull request #248 from github/main-pkg
Move main package to under `cmd/`
2020-01-23 09:34:54 -06:00
Nate Smith
91ab3086a8 Merge pull request #249 from github/issue-pr-argument-docs
Avoid saying "number as argument" for `issue/pr view`
2020-01-23 09:31:18 -06:00
Mislav Marohnić
30b4eab8e0 Use ghrepo.FullName in tests 2020-01-23 14:24:22 +01:00
Mislav Marohnić
22fe0839fa Merge remote-tracking branch 'origin/master' into ghrepo-interface 2020-01-23 14:19:10 +01:00
Mislav Marohnić
e81a29c076 Merge pull request #238 from github/pr-create-just-works-TM
Support triangular git workflows in `pr create`
2020-01-23 14:11:17 +01:00
Mislav Marohnić
4f6dfee965 Merge remote-tracking branch 'origin/master' into pr-create-just-works-TM 2020-01-23 14:08:07 +01:00
Mislav Marohnić
f10b8d8095 Add unit tests for remotes-to-repos resolver 2020-01-23 14:05:15 +01:00
Mislav Marohnić
9122bc181c Migrate away from errors.Wrap()
Turns out the "standard" way of wrapping errors in Go is via
`fmt.Errorf("%w")`, which doesn't require an external package and also allows a
finer control of error sentence formatting.
2020-01-23 13:19:28 +01:00
Mislav Marohnić
f58dd04074 Avoid saying "number as argument" for issue/pr view
Since issue URLs, PR URLs, and PR branch names are all accepted as arguments,
avoid explicitly requesting "number" as argument.
2020-01-23 13:09:37 +01:00
Mislav Marohnić
537b0a8429 Friendlier output for network connectivity errors
For `net.DNSError`, the full error message can be scary. Instead, print "error
connecting to HOST" and hint that the user should check their internet connection
or githubstatus.com.

When $DEBUG is set, the full DNS error is printed like before.

Fixes #206
2020-01-23 12:48:10 +01:00
Mislav Marohnić
eb6541d8d6 Fix CI build 2020-01-23 11:03:06 +01:00
Mislav Marohnić
6282a3c24e Improve readability of error output
Ensure a blank line between error and usage output
2020-01-23 11:00:23 +01:00
Mislav Marohnić
02f5a68937 Move main package to under cmd/
It's a Go convention that main packages (one per each binary produced) are
scoped under `cmd/`.

https://github.com/github/go-lang/blob/master/docs/style-guide.md#directory-structure-and-filenames-layout
2020-01-23 10:45:28 +01:00
Mislav Marohnić
f5ad43458c Avoid using <...> in docs
When converted to HTML docs, these get interpreted as HTML tags.

In theory, we could encapsulate these bits in backticks, but the docs are
already in raw Go string literals, and we can't easily escape backticks in that
context. Instead, just avoid using `<>` for now.
2020-01-23 10:28:29 +01:00