Commit graph

9525 commits

Author SHA1 Message Date
Kynan Ware
bcd47f1fb1 fix(api): correct var name capitalization 2025-05-15 09:13:46 -06:00
Kynan Ware
ea85b92b35
refactor(api): remove needless parenthesis
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-15 09:09:36 -06:00
Kynan Ware
da40e08746
doc(api): code comment typo
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-15 08:33:30 -06:00
Kynan Ware
5dc854c75e doc(issue edit): clarify synchronous handling of assignees 2025-05-14 11:50:11 -06:00
Kynan Ware
08cd1dc7db feat(issue edit): replacing actor assignee is done synchronously with updateIssue 2025-05-14 11:43:29 -06:00
Kynan Ware
712eeabd4a doc(api): remove needless comment 2025-05-14 08:55:55 -06:00
Kynan Ware
dfd600713f refactor(api): rename assignable user types and methods 2025-05-14 08:53:47 -06:00
Kynan Ware
1e5c3c7426 fix(issue edit): revert rename of ActorAssignees 2025-05-13 13:02:20 -06:00
Kynan Ware
21bd797c6c fix(issue edit): use double quotes for assignedActors 2025-05-13 11:45:40 -06:00
Kynan Ware
261297f0a2 refactor(issue edit): add assignedActors to lookupFields 2025-05-13 07:28:42 -06:00
Kynan Ware
3bed77836a refactor(issue edit): rename loop variable for clarity 2025-05-13 07:11:24 -06:00
Kynan Ware
35792827ad refactor(issue edit): rename AssignedActors to ActorAssignees 2025-05-13 07:09:04 -06:00
Kynan Ware
cff2fa71e2 doc(repo queries): clarify reviewer actor fetching logic 2025-05-12 11:49:44 -06:00
Kynan Ware
73e5589059 doc(issue): comment why assignable actors disabled 2025-05-12 11:37:37 -06:00
Kynan Ware
29241cb7a5 refactor(issue edit): improve actor type handling
This improves actor type handling while fetching repository assignable actors.
2025-05-12 11:34:31 -06:00
Kynan Ware
218152f7c5 fix(issue edit): resolve race condition in actor assignment 2025-05-09 23:26:06 -06:00
Kynan Ware
e0afc91fef chore(issue edit): comments cleanup 2025-05-09 23:02:15 -06:00
Kynan Ware
0efdfed068 feat(issue edit): support assigning actors to issues 2025-05-09 22:56:09 -06:00
Kynan Ware
ee9d169204 feat(issue edit): fetch assignable actors 2025-05-09 15:13:11 -06:00
Kynan Ware
38e52db377 feat(issue edit): fetch currently assigned actors 2025-05-09 15:12:07 -06:00
Kynan Ware
8ebbd1d4bf feat(fd): add ActorIsAssignable to IssueFeatures 2025-05-07 12:23:18 -06:00
Azeem Sajid
ee281fd9ba
Add closedByPullRequestsReferences JSON field to issue view (#10941)
* [gh issue view] Expose `closedByPullRequestsReferences` JSON fields

* Incorporate GitHub Copilot review suggestions

* Incorporate review changes
2025-05-07 13:59:22 +01:00
Meredith Lancaster
315876852a
Merge pull request #10670 from malancas/move-predicate-type-filtering
Move predicate type filtering in `gh attestation verify`
2025-05-06 11:08:34 -06:00
William Martin
a2fcb9b2df
Merge pull request #10915 from cli/wm/projectsv1-deprecation-pr-create-rest
Feature detect v1 projects on interactive `pr create`
2025-05-06 15:24:04 +02:00
William Martin
4967a5edd5
Merge pull request #10911 from cli/wm/projectsv1-deprecation-pr-web
Feature detect v1 projects on web mode pr create
2025-05-06 14:19:15 +02:00
Meredith Lancaster
e4ef9bcedd
Merge branch 'trunk' into move-predicate-type-filtering 2025-05-05 14:34:00 -06:00
Kynan Ware
d6d8275809
Merge pull request #10918 from cli/kw/fix-accessible-prompter-flaky-test
Fix flakey test for accessible prompter
2025-05-02 14:59:39 -06:00
Kynan Ware
cc673cfaba test(prompter): add timeout before password input 2025-05-02 14:48:07 -06:00
Kynan Ware
7b86830ade
Merge pull request #10729 from nopcoder/trunk
Fix panic on `gh pr view 0`
2025-05-02 09:47:48 -06:00
William Martin
1a5b7ca60c Feature detect v1 projects for preview URL
As far as I can see, when there is project metadata, the preview option
will never be shown in the interactive multiselect, so I don't believe
this change has any functional difference. However, I did use the
opportunity to drive out tests for generateCompareURL
2025-05-02 17:42:23 +02:00
William Martin
5a3aee056a Feature detect v1 projects on interactive pr create 2025-05-02 17:42:23 +02:00
William Martin
5ee70748fa
Merge pull request #10909 from cli/wm-kw/projectsv1-deprecation-pr-create
Feature detect v1 projects on non-interactive pr create
2025-05-02 15:23:11 +02:00
William Martin
9822bb5d07 Feature detect v1 projects on web mode pr create 2025-05-02 15:11:04 +02:00
William Martin
e995a873cb Feature detect v1 projects on non-interactive pr create 2025-05-02 15:08:34 +02:00
William Martin
c5d8e6f8f5
Merge pull request #10821 from cli/wm/projectsv1-deprecation-pr-view
Feature detect v1 projects on pr view
2025-05-02 15:07:40 +02:00
William Martin
64370ce73e Cleanup run command stubbed finders in tests 2025-05-02 14:48:52 +02:00
Babak K. Shandiz
284880c21e
Fix StatusJSONResponse usage (#10810)
* Fix `StatusJSONResponse` usage

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Replace `assert` with `require`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Improve assertion against errors

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Add `JSONErrorResponse` helper func

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `httpmock.JSONErrorResponse`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Replace `StatusJSONResponse` to `JSONErrorResponse` for better readibility

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix improper use of `StatsJSONResponse`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-01 20:22:43 +01:00
Barak Amar
232c024987
Merge branch 'trunk' into trunk 2025-05-01 22:16:55 +03:00
William Martin
3bcf9758ad Feature detect v1 projects on pr view 2025-05-01 15:31:36 +02:00
Sinan Sonmez (Chaush)
0a1e7a1fdc
Add --delete-last option to pr comment and issue comment (#10596)
* deletion for issues with confirmation flag

* add handling for interaction case

* finish implementation for issues

* finish the implementation for issues

* finalize the implementation for PR

* fix missing --yes flag for PR

* address PR comments related to feedbacks

* improve CommentablePreRun for pre checks

* improve confirmation prompt and truncate long comment body

* address PR comments on tests

* Truncate comment for confirmation prompt

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Improve test case descriptions

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix mock comment body

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Remove irrelevant prompt stub

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `opts.Interactive` as TTY indicator

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix expected `Interactive` value

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Polish `TestNewCmdComment`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-05-01 14:12:55 +01:00
Andy Feller
913d13539d
Merge pull request #10869 from cli/dependabot/go_modules/github.com/cpuguy83/go-md2man/v2-2.0.7
chore(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.6 to 2.0.7
2025-05-01 08:20:27 -04:00
Andy Feller
3abc43b770
Merge pull request #10886 from cli/dependabot/github_actions/actions/attest-build-provenance-2.3.0
chore(deps): bump actions/attest-build-provenance from 2.2.2 to 2.3.0
2025-05-01 08:07:07 -04:00
Meredith Lancaster
050c68c13b
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-30 14:14:42 -06:00
Andy Feller
c20a4a2ae9
Merge pull request #10890 from cli/andyfeller/gh-accessibility-help-topic
Introduce `gh accessibility` help topic highlighting GitHub CLI accessibility experiences
2025-04-30 15:40:27 -04:00
Andy Feller
830335d920 PR feedback 2025-04-30 15:05:07 -04:00
Andy Feller
c20138d844
Update pkg/cmd/accessibility/accessibility.go 2025-04-30 14:35:35 -04:00
Andy Feller
2fd1a45a81
Update pkg/cmd/accessibility/accessibility.go 2025-04-30 14:21:02 -04:00
Andy Feller
096106a3d7
Apply suggestions from code review
Co-authored-by: Melissa Xie <mxie@users.noreply.github.com>
2025-04-30 14:20:16 -04:00
Andy Feller
f6dd699703
Merge pull request #10906 from cli/kw/typo-in-prompter
Small typo in code comment.
2025-04-30 10:14:56 -04:00
Kynan Ware
00c930d509
doc(prompter): small typo 2025-04-30 08:04:16 -06:00