Commit graph

4884 commits

Author SHA1 Message Date
Jeff Hubbard
c18e54189c Adds a timeout context to the ssh waiter to prevent indefinite hanging 2021-10-27 15:40:49 -07:00
rsteube
d794a929da
Fix stack overflow in AddJSONFlags (#4614)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-27 14:56:59 +02:00
Mislav Marohnić
cbd6569cb4
Bump bluemonday to silence the security alert (#4607)
GitHub CLI is not affected by GHSA-x95h-979x-cf3j, since we are not
vulnerable to XSS via HTML injection, but upgrading the library might
silence the security alert.
2021-10-25 19:43:41 +02:00
Mislav Marohnić
a843cbd728 Mark codespace a core command 2021-10-25 19:42:22 +02:00
Mislav Marohnić
31ba2ea4d5
Publish codespace commands (#4606) 2021-10-25 17:38:00 +00:00
Mislav Marohnić
0a0ed3986d
Merge pull request #4608 from srivatsn/srivatsn/vscodebranding
Update help text codespaces code command
2021-10-25 19:11:32 +02:00
Srivatsn Narayanan
32f1ea5ec0 Update branding of VSCode in the code command 2021-10-25 16:53:28 +00:00
Mislav Marohnić
45ea360e4a
Merge pull request #4605 from cli/no-map-pointers
Remove unnecessary pointers to Go maps
2021-10-25 17:48:47 +02:00
Mislav Marohnić
83a08aa3ba Remove unnecessary pointers to Go maps 2021-10-25 17:20:12 +02:00
Mislav Marohnić
8d9e8e317e
Merge pull request #4591 from cli/codespaces-json-export
Add export functionality to codespace commands
2021-10-25 17:10:32 +02:00
Mislav Marohnić
905cb3b9fa Touch-up codespaces exporting functionality 2021-10-25 15:45:10 +02:00
Mislav Marohnić
ba4a7c671c
Merge pull request #4594 from cli/codespace-create-branch
Make branch input optional in codespace create
2021-10-25 15:28:47 +02:00
Mislav Marohnić
436762dd54 codespace create: make the branch input optional
When blank, the branch name will default to the default branch for the
repository.
2021-10-22 15:43:26 +02:00
Mislav Marohnić
3492109e12 codespace create: avoid unnecessarily fetching user 2021-10-22 14:39:21 +02:00
Mislav Marohnić
a5fa70a07d 🔥 obsolete codespace/output package 2021-10-22 14:18:10 +02:00
Mislav Marohnić
cbeb675e56 codespace ports: support --json and --template export flags 2021-10-22 14:13:43 +02:00
Mislav Marohnić
badbf515cb codespace list: support --json and --template export flags 2021-10-22 14:13:15 +02:00
Sam
884d73d5dd
Merge pull request #4587 from dhiemaz/fixing-docs-numbering
Fixing docs numbering
2021-10-21 11:45:35 -07:00
Sam
7526ea505d
Merge pull request #4586 from dhiemaz/fixing-docs-releasing
fixing numbering in releasing docs for consistency.
2021-10-21 11:41:42 -07:00
dimas
0007dce7f7 fixing numbering in project-layout and source docs for consistency. 2021-10-22 01:29:53 +07:00
dimas
e9dafd7c32 fixing numbering in releasing docs for consistency. 2021-10-22 01:25:23 +07:00
Alan Donovan
2f7f224c9e
Merge pull request #4584 from cli/FlagErrorf
Add FlagErrorf; encapsulate FlagError.error
2021-10-21 14:14:05 -04:00
Nate Smith
1f3478d526
Merge pull request #4568 from cli/bin-ext-dispatch
dispatch binary extensions directly
2021-10-21 12:13:59 -05:00
nate smith
f65c1537dc review feedback 2021-10-21 11:58:25 -05:00
Mateusz Urbanek
67595110e8
Improve table output from codespace list command (#4516)
Co-authored-by: Jose Garcia <josebalius@github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-21 16:42:08 +00:00
Jose Garcia
bbea5ac95e
codespace: progress indication, logging (#4555)
* Rework logging, showing progress, and printing from `codespace` commands
* Change rendering of the general progress indicator so that it's visible on both dark and light backgrounds
* The progress indicator now "spins" faster

Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-21 18:04:04 +02:00
Alan Donovan
f4491c7a80 Add FlagErrorf; encapsulate FlagError.error 2021-10-21 11:40:20 -04:00
Alan Donovan
a199de00be
Merge pull request #4577 from cli/no-remote
gh cs cp: report error if no filename is remote
2021-10-21 10:51:34 -04:00
Alan Donovan
7215522123 use FlagError 2021-10-21 10:06:11 -04:00
Mislav Marohnić
cd9971b9a1
Merge pull request #4582 from stdtom/patch-1
Fix copy/paste mistake in docs
2021-10-21 12:53:08 +02:00
stdtom
9468e9e7df
Fix copy/paste mistake in docs 2021-10-21 12:34:20 +02:00
Alan Donovan
8fb5e5e1d5 Report error if no filename is remote 2021-10-20 14:21:22 -04:00
nate smith
c696416a11 add test 2021-10-19 14:52:14 -05:00
nate smith
42ce8faafa dispatch binary extensions directly 2021-10-19 14:25:33 -05:00
Nate Smith
034199073d
Merge pull request #4566 from cli/delete-scope
Declare that the delete repo endpoint needs `delete_repo` scope
2021-10-19 14:02:09 -05:00
Mislav Marohnić
b9c26dfba3 Declare that the delete repo endpoint needs delete_repo scope
The API endpoint doesn't declare this in its `X-Accepted-Oauth-Scopes`
response header.
2021-10-19 19:16:50 +02:00
Mislav Marohnić
d84a7c7fa7
Merge pull request #4559 from cli/api-pagination-fix
Prevent repeating GET parameters when paginating with api command
2021-10-19 18:54:17 +02:00
Mislav Marohnić
a9b2c0dc82
Merge pull request #4523 from joshmgross/joshmgross/support-localhost
Support github.localhost as a non-enterprise host
2021-10-19 18:37:39 +02:00
Nate Smith
5a3b9ceab0
Merge pull request #4451 from cli/repo-delete
gh repo delete
2021-10-19 11:13:33 -05:00
Sam
5d27e1d272
Merge pull request #4542 from Sixeight/fix-release-create-d-option
People doesn't want to publish release when specify -d option
2021-10-19 09:05:07 -07:00
Sam Coe
2135918c47
Turn survey options into variables so they can't accidentally become unsynced with default value 2021-10-19 08:55:30 -07:00
Alan Donovan
fc1de3aaa0
Merge pull request #4564 from cli/e-flag
gh cs cp: disable remote shell expansion unless -e flag
2021-10-19 11:38:19 -04:00
Alan Donovan
f683d6cb4c Disable remote shell expansion unless -e 2021-10-19 10:11:31 -04:00
Tomohiro Nishimura
c7f79e8447
Set default publish action to draft if --draft option is set 2021-10-19 22:37:46 +09:00
Alan Donovan
b96ccb4d99
Merge pull request #4553 from cli/cs-cp
gh cs cp: copy files between local/remote file systems
2021-10-18 17:32:08 -04:00
Sam
a02d423687
Merge pull request #3822 from owenvoke/feature/gpg-key
feat: add GPG key management commands
2021-10-18 11:36:44 -07:00
Mislav Marohnić
01adff037f api: prevent repeating GET parameters when paginating 2021-10-18 20:18:23 +02:00
Mislav Marohnić
ebc1f2f156 Consistently respect GH_HOST in repo archive/create/garden/view commands 2021-10-18 20:05:53 +02:00
Mislav Marohnić
5f5df817be Fix generated URLs for github.localhost repositories 2021-10-18 20:01:18 +02:00
Mislav Marohnić
2c86e671f3 Enable gh auth login for github.localhost 2021-10-18 20:01:18 +02:00