STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7882 commits 87 branches 0 tags 160 MiB
Commit graph

7882 commits

This branch
This branch
All branches
Author SHA1 Message Date
Andy Feller
d108784d7f
Merge pull request #9618 from cli/wm/tenant-api 
Use api subdomains for tenant hosts
 2024-09-16 09:53:44 -04:00
William Martin
420d80b498 Update go-gh to use api subdomains 2024-09-16 15:21:42 +02:00
Meredith Lancaster
0f42ee46f0
Merge pull request #9612 from cli/bdehamer/attest-verify-no-tty 
Suppress `attestation verify` output when no TTY present
 2024-09-13 10:01:02 -06:00
Meredith Lancaster
e381d54511
Merge pull request #9564 from malancas/verification-err-output 
Update `gh attestation verify` bundle parsing and validation errors
 2024-09-13 09:27:07 -06:00
William Martin
352737cb60 Use api subdomains for commands using ghinstance package 2024-09-13 15:03:36 +02:00
William Martin
4430c40298
Merge pull request #9599 from timrogers/timrogers/extension-arm64 
Suggest installing Rosetta when extension installation fails due to missing `darwin-arm64` binary, but a `darwin-amd64` binary is available
 2024-09-13 13:52:09 +02:00
William Martin
99b789e745 Add test for extension install fallback to amd64 on darwin 2024-09-13 11:59:54 +02:00
William Martin
e0fb793b44 Stub hasRosetta for tests 2024-09-12 13:56:19 -06:00
Tim Rogers
5296d60832
Refactor conditions 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2024-09-12 18:53:24 +01:00
Brian DeHamer
677edbac77
suppress att verify output when no tty 
Signed-off-by: Brian DeHamer <bdehamer@github.com>
 2024-09-12 09:40:47 -07:00
Brian DeHamer
c57a045d2d
Merge pull request #9595 from cli/bdehamer/attest-verify-test-custom-issuer 
`gh attestation verify` test for custom OIDC issuers
 2024-09-12 06:51:05 -07:00
Brian DeHamer
f128ae8349
add att verify test for custom OIDC issuer 
Signed-off-by: Brian DeHamer <bdehamer@github.com>
 2024-09-11 12:49:06 -07:00
William Martin
3cbaffebb6
Merge pull request #9601 from cli/dependabot/go_modules/github.com/sigstore/sigstore-go-0.6.2 
build(deps): bump github.com/sigstore/sigstore-go from 0.6.1 to 0.6.2
 2024-09-11 16:58:32 +02:00
dependabot[bot]
fbdf0ccb75
build(deps): bump github.com/sigstore/sigstore-go from 0.6.1 to 0.6.2 
Bumps [github.com/sigstore/sigstore-go](https://github.com/sigstore/sigstore-go) from 0.6.1 to 0.6.2.
- [Release notes](https://github.com/sigstore/sigstore-go/releases)
- [Commits](https://github.com/sigstore/sigstore-go/compare/v0.6.1...v0.6.2)

---
updated-dependencies:
- dependency-name: github.com/sigstore/sigstore-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-11 14:39:44 +00:00
Andy Feller
22c1da07a2
Merge pull request #9520 from velumuruganr/auth-status-active 
Added `--active` flag to the `gh auth status` command
 2024-09-11 10:35:39 -04:00
Tim Rogers
a0a2567354
Suggest installing Rosetta when extension installation fails due to missing darwin-arm64 binary, but a darwin-amd64 binary is available 
When installing an extension, the CLI must to select the correct
binary to download for the machine (see the
[`installBin` function](78c1d00ecc/pkg/cmd/extension/manager.go (L240))).

By default, the CLI will download a binary matching the current
machine's architecture.

However, to provide better support for Macs running on Apple
Silicon, it will
[fall back](78c1d00ecc/pkg/cmd/extension/manager.go (L267-L274))
from `darwin-arm64` to `darwin-amd64` if
[Rosetta](https://support.apple.com/en-gb/102527) (Apple's
compatibility layer) is installed.

If Rosetta isn't installed, this fallback doesn't happen, which
can lead to surprising and confusing results when one Mac has
Rosetta and another doesn't, because the extension will install
on one machine but not another.

In the situation where a `darwin-arm64` binary isn't available
but the CLI can't fall back to `amd64` because Rosetta isn't
installed, this updates our error message to suggest installing
Rosetta.

Closes https://github.com/cli/cli/issues/9592.
 2024-09-11 11:50:05 +01:00
Fredrik Skogman
aa931c5aa7
Merge pull request #9542 from kommendorkapten/policy-tenancy 
Added tenancy aware attestation commands
 2024-09-11 11:53:30 +02:00
Fredrik Skogman
1b59ec8ad0
This commit introduces tenancy aware attestation policy building. 
This is done by inspecting the current hostname to determine if
tenancy is enabled.

The attestation commands also accepts a --hostname parameter, that
is used to pick the current host, similar to how the GH_HOST variable
can be used.

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
 2024-09-11 10:49:17 +02:00
Meredith Lancaster
e2c33e5cc1 use sigstore-go v0.6.2 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-10 13:07:52 -06:00
Meredith Lancaster
50d335566d check specific err 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-10 10:47:06 -06:00
Meredith Lancaster
3814e82f9b check err in GetLocalAttestations 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-10 10:32:46 -06:00
Meredith Lancaster
f748f9e65f Merge remote-tracking branch 'upstream/trunk' into verification-err-output 2024-09-10 09:04:57 -06:00
Meredith Lancaster
442111075c go mod tidy 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-10 08:04:51 -06:00
Meredith Lancaster
83519e4e92 check for sigstore-go validation errs 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-10 07:54:45 -06:00
Meredith Lancaster
70e935ba95 get latest sigstore-go commit 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-10 07:54:33 -06:00
William Martin
78c1d00ecc
Merge pull request #9577 from cli/move-non-integration-test 
Move non-integration tests to different test file
 2024-09-10 15:43:25 +02:00
Meredith Lancaster
bbefc5b24f handle os.PathError in GetLocalAttestations 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-09 08:53:11 -06:00
Meredith Lancaster
945e2b7eee
Merge branch 'trunk' into verification-err-output 2024-09-09 08:23:01 -06:00
William Martin
a3f9d85fc3
Merge pull request #9575 from cli/dependabot/github_actions/actions/attest-build-provenance-1.4.3 
build(deps): bump actions/attest-build-provenance from 1.4.2 to 1.4.3
 2024-09-09 10:17:38 +02:00
Cody Soyland
3b7b7a4752
Merge pull request #9578 from cli/bundle-panic 
Check for nil values to prevent nil dereference panic
 2024-09-06 16:17:53 -04:00
Cody Soyland
b14e430441
Check for nil values to prevent nil dereference panic 
Signed-off-by: Cody Soyland <codysoyland@github.com>
 2024-09-06 15:22:43 -04:00
Cody Soyland
500b619a5e
Move non-integration test to different test file 
Signed-off-by: Cody Soyland <codysoyland@github.com>
 2024-09-06 13:55:25 -04:00
Andy Feller
82b509958a
Merge pull request #9566 from cli/sigstore-go-v0.6.1 
Upgrade sigstore-go to v0.6.1
 2024-09-06 11:14:43 -04:00
dependabot[bot]
a21e78bf0d
build(deps): bump actions/attest-build-provenance from 1.4.2 to 1.4.3 
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](6149ea5740...1c608d11d6)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-09-06 14:31:25 +00:00
William Martin
dd85d621c6
Merge pull request #9573 from cli/andyfeller/9569-remove-old-gpg-id-notes 
Remove note explaining 2 year old GPG ID change
 2024-09-06 14:56:32 +02:00
Andy Feller
5a7cdff9db Update linux install to point to GPG troubleshoot 
Relates #9569

Updates notes from older 2 year GPG ID change to redirect users in case of GPG errors to recent issue.
 2024-09-06 08:45:24 -04:00
Andy Feller
78fa57dff7 Revert "Remove note explaining 2 year old GPG ID change" 
This reverts commit 043bdbedb9.
 2024-09-06 08:41:59 -04:00
Andy Feller
043bdbedb9 Remove note explaining 2 year old GPG ID change 
Relates #9569

Having been 2 years since the GitHub CLI changed GPG keys used to sign our releases, it no longer seems relevant to keep these notes in our installation docs as they are confusing to the uninitiated.
 2024-09-06 08:36:04 -04:00
Meredith Lancaster
668706ccf5 print verify err 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-05 13:29:22 -06:00
Meredith Lancaster
57b20291bd check for os.PathError 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-05 13:20:13 -06:00
Meredith Lancaster
7c405e8b6e dont print err content 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-05 08:16:34 -06:00
Cody Soyland
ea1a3da1eb
Rename ProtobufBundle to Bundle 
Signed-off-by: Cody Soyland <codysoyland@github.com>
 2024-09-04 16:45:02 -04:00
Cody Soyland
8446079656
Upgrade to sigstore-go v0.6.1 
Signed-off-by: Cody Soyland <codysoyland@github.com>
 2024-09-04 16:38:13 -04:00
Meredith Lancaster
1b67b354a9 update bundle file parsing err messages 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-04 13:30:30 -06:00
Meredith Lancaster
34d7ef7a0e
gh attestation verify handles empty JSONL files (#9541) 
* handle empty jsonl files

Signed-off-by: Meredith Lancaster <malancas@github.com>

* check processed attestations slice length

Signed-off-by: Meredith Lancaster <malancas@github.com>

* update err name and message

Signed-off-by: Meredith Lancaster <malancas@github.com>

---------

Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-09-04 10:31:41 -06:00
Aryan Bhosale
9a0a7d427e
verify 2nd artifact without swapping order (#9532) 
* verify 2nd artifact without swapping order

possible solution to https://github.com/cli/cli/issues/9521#issuecomment-2310686619?

* copy the mentioned test file and adds some extra lines

* rm unnecessary import

* Update pkg/cmd/attestation/verification/attestation_test.go

Co-authored-by: Meredith Lancaster <malancas@users.noreply.github.com>

* gofmt

---------

Co-authored-by: Meredith Lancaster <malancas@users.noreply.github.com>
 2024-09-04 08:57:56 -06:00
William Martin
2bd3c22903
Merge pull request #9555 from crystalstall/trunk 
chore: fix some function names
 2024-09-02 11:43:32 +02:00
crystalstall
5562c1489f chore: fix some function names 
Signed-off-by: crystalstall <crystalruby@qq.com>
 2024-09-02 15:18:42 +08:00
Andy Feller
03c34e71f9 Expand active test cases 2024-08-30 10:57:51 -04:00
Zongle Wang
192f57ef42
Improve the help message for -F (#9525) 
Changing to `release-notes.md` from `changelog.md` may help users better contextually understand usage.

Co-authored-by: Tyler McGoffin <jtmcg@github.com>
 2024-08-28 11:00:46 -07:00