Commit graph

42 commits

Author SHA1 Message Date
Andy Feller
0180c7fce4 Restored original test setup, clarified
After discussing my previous change to the test, I'm restoring the previous keyring setup to reflect the specific situation.

I added clarifying comments to help the next reviewer.
2025-06-20 15:38:09 -04:00
Andy Feller
b7c2b19e70 Enhance Activetoken prioritize test
- ensure test user tokens are different from unkeyed token
- ensure assertion expected / actual are in correct order
2025-06-20 14:36:45 -04:00
Anuraag Agrawal
848cedd2c8 Push up 2025-06-18 09:56:44 +09:00
Anuraag Agrawal
cc9a2411e0 Cleanup 2025-05-29 12:28:26 +09:00
Anuraag Agrawal
f294a5f533 fix: get token for active user instead of blank if possible 2025-05-29 12:13:21 +09:00
bagtoad
e7403b89d0 Add HasActiveToken to AuthConfig.
Co-authored-by: William Martin <williammartin@users.noreply.github.com>
2024-09-18 08:42:19 -06:00
William Martin
1d38230675
Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
Sam Coe
024cb939af Rename authCfg.Token to authCfg.ActiveToken and authCfg.SetToken to authCfg.SetActiveToken 2023-12-06 14:06:28 +01:00
Sam Coe
1a3392a379 Rename authCfg.User to authCfg.ActiveUser 2023-12-06 14:06:28 +01:00
Sam Coe
8cdbc1a8ca Refactor authCfg.UsersForHost to not return an error 2023-12-06 14:06:28 +01:00
William Martin
af8bcd3ed2 Print useful error when switch fails outside user control 2023-12-06 14:06:28 +01:00
William Martin
4e04b98f6f Add user flag to auth token command 2023-12-06 14:06:28 +01:00
William Martin
7106129f65 Restore previous happy state on Switch failure 2023-12-06 14:06:28 +01:00
William Martin
ecfb226d5d Fix linting errors 2023-12-06 14:06:28 +01:00
William Martin
ab5103f061 Don't set user level git protocol and don't switch 2023-12-06 14:06:28 +01:00
William Martin
553b89f30c Add tests for AuthConfig TokenForUser 2023-12-06 14:06:28 +01:00
William Martin
c9a6b7cc00 Always mock the keyring in NewIsolatedTestConfig 2023-12-06 14:06:28 +01:00
William Martin
8e89af96e8 Write tests for SwitchUser 2023-12-06 14:06:28 +01:00
William Martin
a0e5e4c709 Use NewIsolatedTestConfig in AuthConfig tests 2023-12-06 14:06:28 +01:00
William Martin
72d5550407 Implemented auth logout for multiaccount 2023-12-06 14:06:28 +01:00
William Martin
1bf6023164 Display message when logging into existing account 2023-12-06 14:06:28 +01:00
Sam Coe
38b73e3f85 Set host level git_protocol on login 2023-12-06 14:06:28 +01:00
Sam Coe
eb771aecc9 Address PR comments 2023-12-06 14:06:28 +01:00
Sam Coe
68e30beac4 Logout removes token from keyring using username 2023-12-06 14:06:28 +01:00
Sam Coe
2ca8b1ea94 Login sets token in keyring using username 2023-12-06 14:06:28 +01:00
Sam Coe
d8084f5f6d Hide all keyring package implementation inside internal keyring package 2023-12-06 14:06:28 +01:00
William Martin
9efa7248a9 Initial multi-account migration work 2023-12-06 14:06:28 +01:00
Sam Coe
7924878315
Fix git protocol and refactor Config interface (#8246) 2023-10-27 15:42:05 +02:00
Sam Coe
20baccfa85
Add default configuration back from go-gh (#8244) 2023-10-24 13:23:31 +02:00
William Martin
4fc1999847 Add link to token source issue 2023-10-19 15:39:10 +02:00
William Martin
7d8c1af009 Fix GitProtocol signature and rework test descriptions 2023-10-19 12:49:38 +02:00
William Martin
c430da7329 Ensure all AuthConfig tests are isolated on disk 2023-10-19 12:31:41 +02:00
William Martin
c9de817865 Avoid using keyring unnecessarily in AuthConfig tests
This is to avoid the impression that the keyring matters, when the test
is actually about general auth behaviour
2023-10-19 12:26:52 +02:00
William Martin
fa80802c81 Add tests for AuthConfig DefaultHost 2023-10-19 12:24:25 +02:00
William Martin
07f5ca48d8 Share config.Read setup in AuthConfig tests 2023-10-19 12:24:05 +02:00
William Martin
e0bc2ff0ca Add test that host is added on Login 2023-10-19 12:08:03 +02:00
William Martin
cb7672e573 Add additional comment on Logout ignoring errors 2023-10-19 12:05:40 +02:00
William Martin
3380831672 Rewrite AuthConfig User and GitProtocol tests 2023-10-19 12:05:14 +02:00
William Martin
e011633cdc Add tests for AuthConfig HasEnvToken 2023-10-18 18:10:00 +02:00
William Martin
07110eca33 Add tests for AuthConfig Token 2023-10-18 17:51:53 +02:00
William Martin
614e49296b Add tests for AuthConfig Login and Logout 2023-10-18 17:09:20 +02:00
William Martin
34b0b33f24 Add initial AuthConfig tests 2023-10-18 16:31:13 +02:00