STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8380 commits 87 branches 0 tags 160 MiB
Commit graph

8380 commits

This branch
This branch
All branches
Author SHA1 Message Date
Meredith Lancaster
e97d01f265 use different file name for attestation files on windows 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-09 17:32:55 -07:00
Andy Feller
acfdae466e
Merge pull request #10009 from cli/wm/safepaths 
Use safepaths for run download
 2024-12-05 11:43:10 -05:00
Meredith Lancaster
90dfefbefb
Merge pull request #10019 from malancas/gh-attestation-oci-attestations-bug 
Fix bug when fetching bundles from OCI registry
 2024-12-05 09:41:56 -07:00
Meredith Lancaster
2137a483de include alg with digest when fetching bundles from OCI 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-05 09:27:14 -07:00
William Martin
9bd8f09774 Use safepaths for run download 2024-12-04 22:12:58 +01:00
Andy Feller
179f0c479e
Merge pull request #10006 from cli/10005-fix-flaky-run-download-test 
Use consistent slice ordering in run download tests
 2024-12-04 08:13:20 -05:00
William Martin
a47b4c9f1d Use consistent slice ordering in run download tests 2024-12-04 13:02:25 +01:00
Tyler McGoffin
1136764c36
Merge commit from fork 
The fix
 2024-12-03 15:12:05 -08:00
Andy Feller
8720479b0b Consolidate logic for isolating artifacts 2024-12-03 13:33:00 -05:00
William Martin
7c241cf4e6
Merge pull request #9992 from cli/wm/fix-pr-checkout-panic 
Fix PR checkout panic when base repo is not in remotes
 2024-12-03 14:04:32 +01:00
William Martin
694e565384 Fix PR checkout panic when base repo is not in remotes 2024-12-02 17:20:57 +01:00
Andy Feller
5a74934d19
Merge pull request #9983 from timrogers/timrogers/fork-rename 
When renaming an existing remote as part of remote creation in `gh repo fork`, log the change
 2024-12-02 10:30:03 -05:00
Kynan Ware
67df4a39fe
Merge pull request #9976 from cli/kw/Improve-DNF-version-clarity-in-install-steps 
Clarify which commands correspond to which DNF version under Linux install instructions
 2024-12-02 06:08:47 -07:00
William Martin
8d8ac515d0
Merge pull request #9942 from cli/dependabot/go_modules/github.com/gabriel-vasile/mimetype-1.4.7 
Bump github.com/gabriel-vasile/mimetype from 1.4.6 to 1.4.7
 2024-12-02 14:03:25 +01:00
Tim Rogers
c719d920c3
When renaming an existing remote in gh repo fork, log the change 
When running `gh repo fork` in the context of an existing repo, the CLI offers to create a remote for the fork:

```
? Would you like to add a remote for the fork? Yes
```

If you accept, it prints a log stating that the `origin` remote has been created:

```
âś“ Added remote origin
```

Where there is an existing `origin` remote, this is renamed to `upstream`, but this is done silently without any notification to the user.

```bash
$ git remote -v
origin	https://github.com/timrogers/badger.github.io.git (fetch)
origin	https://github.com/timrogers/badger.github.io.git (push)
upstream	https://github.com/badger/badger.github.io.git (fetch)
upstream	https://github.com/badger/badger.github.io.git (push)
```

It seems kinda fine to rename the remote without explicitly confirming since this is not a truly destructive action, but it should make it clear what it is doing.

This updates the logging to explicitly log about the renaming of
the existing remote:

```
âś“ Renamed remote origin to upstream
```

Fixes #9982.
 2024-11-30 21:19:55 +00:00
Kynan Ware
4f4602a682 Improve DNF version clarity in install steps 2024-11-29 16:34:41 -07:00
Andy Feller
9983939d53
Merge pull request #9969 from cli/kw/fix-formatting-for-linter-git-client_test.go 
Fix formatting in `git/client_test.go` comments for linter
 2024-11-27 16:32:02 -05:00
bagtoad
76f1553fb9 Fix formatting in client_test.go comments for linter 2024-11-27 14:19:27 -07:00
Andy Feller
1fe14c956d
Merge commit from fork 
Use only one pattern for credential helper matching
 2024-11-27 15:57:08 -05:00
Andy Feller
c94def8b51 Bump cli/go-gh for codespace fix 2024-11-27 15:54:38 -05:00
William Martin
ec086a021b
Update git/client_test.go 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2024-11-27 15:51:44 +01:00
William Martin
622e283d2b
Update git/client_test.go 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2024-11-27 15:51:38 +01:00
William Martin
21a14a7d1a
Update git/client_test.go 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2024-11-27 15:50:54 +01:00
William Martin
bd44d33eaa Add checkout test that uses ssh git remote url 2024-11-27 13:06:35 +01:00
William Martin
72a6fd00a4 Rename backwards compatible credentials pattern 2024-11-27 12:21:55 +01:00
William Martin
0b4f087b46 Fix CredentialPattern doc typos 
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2024-11-27 12:07:04 +01:00
William Martin
3773068f58 Remove TODOs 2024-11-27 12:06:17 +01:00
Tyler McGoffin
ad397bd0a6 Fix typos and add tests for CredentialPatternFrom* functions 2024-11-26 16:08:51 -08:00
William Martin
0db05ff022 Add SSH remote todo 2024-11-26 22:30:19 +01:00
William Martin
efd8ff6d46 General cleanup and docs 2024-11-26 22:30:11 +01:00
William Martin
19d62826d6 Allow repo sync fetch to use insecure credentials pattern 2024-11-26 22:30:07 +01:00
William Martin
6b7f1ff060 Allow client fetch to use insecure credentials pattern 2024-11-26 22:30:03 +01:00
William Martin
7affcadb5e Allow client push to use insecure credential pattern 2024-11-26 22:29:58 +01:00
William Martin
75712de712 Allow client pull to use insecure credential pattern 2024-11-26 22:29:51 +01:00
William Martin
5f5c5270c9 Allow opt-in to insecure pattern 2024-11-26 22:29:43 +01:00
William Martin
46922694dc Support secure credential pattern 2024-11-26 22:29:38 +01:00
Andy Feller
b133f9cce0
Merge pull request #9791 from cli/kw/cli-9773-informative-message-for-workflow-scope 
Print friendly error when `release create` fails due to missing `workflow` OAuth scope
 2024-11-26 08:30:59 -05:00
bagtoad
deb34d6456 Refactor error handling for missing "workflow" scope in createRelease 2024-11-23 16:59:49 -07:00
bagtoad
11dc6df88b ScopesResponder wraps StatusScopesResponder 2024-11-23 13:19:45 -07:00
Kynan Ware
a4f96d29e3 Refactor workflow scope checking 
Refactor the logic for checking `workflow` scope checking in releases to be in the positive - check if the scope is there, not check if it isn't there. Then, when the function is called we invert it.

Also update comments to be more imperative.

This refactor also incorporates @andyfeller's suggestion to use `slices`.

Co-Authored-By: Andy Feller <andyfeller@github.com>
 2024-11-23 13:17:09 -07:00
Andy Feller
cdfc12caf5 Expand logic and tests to handle edge cases 
This commit expands filepathDescendsFrom(string, string) to handle edge cases such as mixing absolute and relative paths or artifact name edge cases.

Additionally, tests for filepathDescendsFrom() and downloadrun() have been expanded to verify additional use cases.
 2024-11-22 15:26:11 -05:00
Kynan Ware
ae87caf8d6
Merge pull request #9948 from cli/kw/use-heredoc-for-several-command-docs 
Fix some multiline command documentation to use `heredoc` strings
 2024-11-22 10:11:32 -07:00
Phill MV
f84c1c6f51
Merge pull request #9937 from malancas/verify-result-processing 
Update verification results printing
 2024-11-22 10:54:34 -05:00
Kynan Ware
50e5d94a82
Merge branch 'trunk' into dependabot/go_modules/github.com/gabriel-vasile/mimetype-1.4.7 2024-11-21 22:55:23 -07:00
Meredith Lancaster
f92d703554 pr feedback 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-11-21 15:40:15 -07:00
Meredith Lancaster
0fd09eb5ff pr feedback 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-11-21 15:30:41 -07:00
Meredith Lancaster
fed3c8142c
Update pkg/cmd/attestation/verify/attestation_integration_test.go 
Co-authored-by: Phill MV <phillmv@github.com>
 2024-11-21 15:20:44 -07:00
Andy Feller
e7c5706336 Refactor download testing, simpler file descends 
This incorporates the work done by @williammartin to improve reasoning about `gh run download` behavior through testing while verifying a simpler solution to checking if a path is contained within a directory.
 2024-11-21 17:07:27 -05:00
Kynan Ware
74f13a9b4f
Apply suggestions from code review 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2024-11-21 13:55:35 -07:00
bagtoad
677ed2cdcf Refactor command documentation to use heredoc 2024-11-21 13:23:03 -07:00