Commit graph

102 commits

Author SHA1 Message Date
Billy Griffin
8340591ad3
Number is more readable 2020-02-27 11:23:37 -07:00
Billy Griffin
b18ea98436
Improve error message for issue URL with no args 2020-02-27 11:22:39 -07:00
Mislav Marohnić
adf2177a24
Merge pull request #474 from politas/fix/StripHash
Handle properly passed #<num> as equivalent to <num> for PRs and Issues
2020-02-27 12:15:00 +01:00
Myk
038e5e5342 Accept #<num> syntax as issue/PR number 2020-02-27 12:11:49 +01:00
Dasio
8aa46c236e Init slice with provided capacity if it's known in advance 2020-02-24 22:16:41 +01:00
Mislav Marohnić
38b58a4914 Respect explicit title & body with issue create --web 2020-02-24 13:41:46 +01:00
Mislav Marohnić
ac94ae5872 Return interface from determineBaseRepo(), not pointer to interface
It's sufficient to return a value of type `ghrepo.Interface` instead of
a pointer to an interface. This avoids having to use `*` whenever we are
passing the result of `determineBaseRepo()` into another function that
accepts a `ghrepo.Interface`.
2020-02-24 13:40:58 +01:00
Mislav Marohnić
4c3e498021 Fix column alignment and truncation for Eastern Asian languages
- Ensure that text is never truncated mid-character, which would result
  in garbled text

- Ensure that columns in `issue/pr list` output align properly
2020-02-20 18:52:17 +01:00
Mislav Marohnić
13dbfa44c2 go fmt 2020-02-20 13:55:55 +01:00
Nate Smith
c65ac4ae9d
Merge branch 'master' into glamour-markdown 2020-02-18 14:23:49 -06:00
Anowar Islam
2c2c8a9991
added fix for empty body in issue preview 2020-02-13 01:44:03 -08:00
vilmibm
4f10a6d813 do not use local template files if overriding base repo 2020-02-12 08:57:55 -06:00
vilmibm
135c63aa36 remove --self for now 2020-02-11 20:46:46 -06:00
vilmibm
ad170118e4 use resolve remotes code in issue commands 2020-02-11 19:43:02 -06:00
Nicolas Martin
950144945f Use glamour as markdown rendering backend for issue & pr previews
glamour uses the CommonMark compliant Goldmark markdown parser instead of
go-termd which is based on Blackfriday.
2020-02-06 00:20:16 +01:00
TaKO8Ki
6f2d7c5dd1 fx typo 2020-02-02 17:23:51 +09:00
vilmibm
d7bf83a82c strip color, add whitespace 2020-01-30 14:00:43 -06:00
vilmibm
d81cf009f5 simpler repo context 2020-01-29 17:47:29 -06:00
vilmibm
86cb09fe84 Revert "print repo info for status commands"
This reverts commit d64dcdca95.
2020-01-29 17:41:36 -06:00
vilmibm
d64dcdca95 print repo info for status commands 2020-01-29 15:50:04 -06:00
Mislav Marohnić
a710893fc1 Rename to cli/cli 2020-01-24 16:08:52 +01:00
Mislav Marohnić
b44dad2319 Merge remote-tracking branch 'origin/master' into no-errors-wrap 2020-01-23 16:46:56 +01:00
Nate Smith
a0f2e1736a Merge pull request #244 from github/ghrepo-interface
Extract common interface for a GitHub Repository
2020-01-23 09:39:16 -06:00
Nate Smith
bf0f345ea3 Merge pull request #243 from github/display-url
Extract helper for URL display
2020-01-23 09:36:40 -06:00
Mislav Marohnić
c5960f0906 Merge remote-tracking branch 'origin/master' into ghrepo-interface 2020-01-23 16:36:22 +01:00
Nate Smith
55a5d19252 Merge pull request #247 from github/issue-pr-view-docs
Tweak `issue/pr view` documentation
2020-01-23 09:35:38 -06:00
Mislav Marohnić
22fe0839fa Merge remote-tracking branch 'origin/master' into ghrepo-interface 2020-01-23 14:19:10 +01:00
Mislav Marohnić
9122bc181c Migrate away from errors.Wrap()
Turns out the "standard" way of wrapping errors in Go is via
`fmt.Errorf("%w")`, which doesn't require an external package and also allows a
finer control of error sentence formatting.
2020-01-23 13:19:28 +01:00
Mislav Marohnić
f58dd04074 Avoid saying "number as argument" for issue/pr view
Since issue URLs, PR URLs, and PR branch names are all accepted as arguments,
avoid explicitly requesting "number" as argument.
2020-01-23 13:09:37 +01:00
Mislav Marohnić
f5ad43458c Avoid using <...> in docs
When converted to HTML docs, these get interpreted as HTML tags.

In theory, we could encapsulate these bits in backticks, but the docs are
already in raw Go string literals, and we can't easily escape backticks in that
context. Instead, just avoid using `<>` for now.
2020-01-23 10:28:29 +01:00
Mislav Marohnić
90f6a73ba5 Extract helper to print a URL 2020-01-22 23:03:23 +01:00
Mislav Marohnić
1f90579d2a Extract common interface for a GitHub Repository
Also define a handful of utility methods:
- `New(owner, repo)`
- `FullName`: the name slash owner pair
- `FromFullName`: parse the name slash owner pair
- `FromURL`: parse a GitHub.com URL
- `IsSame(r1, r2)`: compare two repositories
2020-01-22 22:44:46 +01:00
vilmibm
bfdf89b579 updated based sorting and fuzzy time display on issue status 2020-01-17 15:38:41 -06:00
Tiernan L
99c17c3a5f Merge pull request #227 from github/typoswap
Typo fixes for Issue/PR preview text
2020-01-16 16:51:02 -08:00
vilmibm
31001877bd hide potentially long query strings when printing urls 2020-01-16 14:18:40 -06:00
vilmibm
32461284cc fix some TODOs 2020-01-15 12:35:28 -06:00
vilmibm
3468a46521 support preview in browser for issue create 2020-01-15 11:27:12 -06:00
Tiernan L
82d0060eb4 terminal notice 2020-01-14 11:26:44 -10:00
Tiernan L
42f876354d fix typo 2020-01-14 10:34:05 -10:00
Nate Smith
42f58eac4b Merge pull request #203 from github/preview-things
Preview issues and PRs on the terminal
2020-01-13 17:59:34 -06:00
vilmibm
5bc6d220c4 review feedback 2020-01-13 15:32:07 -06:00
Nate Smith
c5486ee3f2 Merge pull request #210 from github/noprinting
minor text edits
2020-01-13 12:19:01 -06:00
vilmibm
f911a234c2 print to proper handle 2020-01-10 15:12:54 -06:00
vilmibm
4925c3cf01 preview PRs and issues in the terminal with -p 2020-01-10 11:41:26 -06:00
Tiernan L
025845e9ff browser is sufficient
We used "browser" and "web browser" in multiple places. I made them all consistent.
2020-01-09 15:29:11 -10:00
Corey Johnson
c9bcf807b1 Make it work with PRs 2020-01-08 12:31:23 -08:00
Corey Johnson
3eb820631d Add "and x more" text" 2020-01-07 14:51:49 -08:00
Corey Johnson
2e0ea153d5 Merge remote-tracking branch 'origin/master' into appropriate-context-and-feedback 2020-01-06 09:52:26 -08:00
Mislav Marohnić
fb0472a868 Merge pull request #176 from github/issue-pr-templates
Add template support to `issue create`, `pr create`
2019-12-23 13:41:15 +01:00
Corey Johnson
8f74b658b2 Merge remote-tracking branch 'origin/master' into appropriate-context-and-feedback 2019-12-20 11:51:37 -08:00