cli/pkg/cmd/pr
Tyler McGoffin e1423cdbbf Refine error handling of ReadBranchConfig
cmd.Output() will return an error when the git command ran successfully
but had no output. To handle this, we can check Stderr, as we expect it to
be populated for any ExitErrors or otherwise when there is a command
failure.

This allows for propagation of this error handling up the call chain, so
we are now returning errors if the call to git fails instead of just
handing off an empty BranchConfig and suppressing the errors.

Additionally, I've removed some more naked returns that I found in
pkg/cmd/pr/create.go createRun
2025-01-09 11:45:15 -08:00
..
checkout Fix PR checkout panic when base repo is not in remotes 2024-12-02 17:20:57 +01:00
checks Error for mutually exclusive json and watch flags 2024-12-05 10:23:13 -05:00
close Apply first round of owner/repo#number consistency 2024-03-01 14:03:18 -05:00
comment Fix tests 2024-08-16 10:11:52 -07:00
create Refine error handling of ReadBranchConfig 2025-01-09 11:45:15 -08:00
diff Fix tests 2024-08-16 10:11:52 -07:00
edit Replace --project.* flags' name with title in docs (#9443) 2024-08-09 13:55:14 -07:00
list Fix tests 2024-08-16 10:11:52 -07:00
merge Return err instead of silentError in merge queue check 2024-12-12 15:54:01 -07:00
ready Apply first round of owner/repo#number consistency 2024-03-01 14:03:18 -05:00
reopen Fix breaking test for PR/issue # change 2024-03-01 16:04:24 -05:00
review Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
shared Remove named returns from ReadBranchConfig and surface errors 2025-01-07 13:54:43 -08:00
status Refine error handling of ReadBranchConfig 2025-01-09 11:45:15 -08:00
update-branch Rename package directory and files 2024-07-17 18:52:23 +01:00
view Adding option to return baseRefOid in pr view 2024-11-19 23:50:45 +02:00
pr.go Rename package directory and files 2024-07-17 18:52:23 +01:00