cli/pkg/cmd/pr/create
Tyler McGoffin e1423cdbbf Refine error handling of ReadBranchConfig
cmd.Output() will return an error when the git command ran successfully
but had no output. To handle this, we can check Stderr, as we expect it to
be populated for any ExitErrors or otherwise when there is a command
failure.

This allows for propagation of this error handling up the call chain, so
we are now returning errors if the call to git fails instead of just
handing off an empty BranchConfig and suppressing the errors.

Additionally, I've removed some more naked returns that I found in
pkg/cmd/pr/create.go createRun
2025-01-09 11:45:15 -08:00
..
fixtures/repoWithNonLegacyPRTemplates/.github/PULL_REQUEST_TEMPLATE Fix failing tests for Windows (due to line-ending issues) 2020-09-02 10:03:56 +05:30
create.go Refine error handling of ReadBranchConfig 2025-01-09 11:45:15 -08:00
create_test.go Remove named returns from ReadBranchConfig and surface errors 2025-01-07 13:54:43 -08:00
regexp_writer.go Refactor regexp writer 2020-11-03 09:59:40 +03:00
regexp_writer_test.go spelling: beginning 2020-11-21 21:43:46 -05:00